cleanup inet_ntoa usage. #12551
Closed
cleanup inet_ntoa usage. #12551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starting with the socket extension. PHP 8 requires windows vista/2008 minimum, even more exotic systems like solaris or haiku supports inet_ntop, so there is no need to keep supporting this old interface.
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Oct 29, 2023
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Oct 29, 2023
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Oct 29, 2023
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Oct 29, 2023
devnexen
added a commit
that referenced
this pull request
Nov 6, 2023
|
@devnexen I think this should rather fail during configure than build... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting with the socket extension. PHP 8 requires windows vista/2008 minimum, even more exotic systems like solaris or haiku supports inet_ntop, so there is no need to keep supporting this old interface.